zeroshade commented on code in PR #475:
URL: https://github.com/apache/iceberg-go/pull/475#discussion_r2219547122
##########
cmd/iceberg/main.go:
##########
@@ -83,7 +83,13 @@ Options:
--description TEXT specify a description for the namespace
--location-uri TEXT specify a location URI for the namespace
--schema JSON specify table schema in json (for create table
use only)
- Ex:
[{"name":"id","type":"int","required":false,"doc":"unique id"}]`
+ Ex:
[{"name":"id","type":"int","required":false,"doc":"unique id"}]
+ --properties TEXT specify table properties in key=value format (for
create table use only)
+
Ex:"format-version=2,write.format.default=parquet"
+ --partition-spec TEXT specify partition spec as comma-separated field
names(for create table use only)
+ Ex:"field1,field2"
+ --sort-order TEXT specify sort order as field:direction format(for create
table use only)
+ Ex:"field1:asc,field2:desc"`
Review Comment:
That's a fair point. I think we'll have to change away from using docopt
unfortunately as I don't think it can easily create that separation (and seems
to be no longer really maintained....).
I think we should probably merge this one and then we can update the way the
parameters are handled afterwards to make them sub-parameters for a `create
table` command and essentially refactor how the CLI works, rather than having
to re-create this PR *after* we do a refactor. that make sense to you
@kevinjqliu ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
