dttung2905 commented on code in PR #475:
URL: https://github.com/apache/iceberg-go/pull/475#discussion_r2190997317
##########
cmd/iceberg/main.go:
##########
@@ -83,7 +83,13 @@ Options:
--description TEXT specify a description for the namespace
--location-uri TEXT specify a location URI for the namespace
--schema JSON specify table schema in json (for create table
use only)
- Ex:
[{"name":"id","type":"int","required":false,"doc":"unique id"}]`
+ Ex:
[{"name":"id","type":"int","required":false,"doc":"unique id"}]
+ --properties TEXT specify table properties in key=value format (for
create table use only)
+
Ex:"format-version=2,write.format.default=parquet"
+ --partition-spec TEXT specify partition spec as comma-separated field
names(for create table use only)
+ Ex:"field1,field2"
+ --sort-order TEXT specify sort order as field:direction format(for create
table use only)
+ Ex:"field1:asc,field2:desc"`
Review Comment:
Hey @zeroshade , I just quickly check
[pyiceberg](https://github.com/apache/iceberg-python/blob/main/pyiceberg/cli/console.py)
and the rust implementation and I do agree with you that they do not support
creating table via CLI
The reason I submitted the PR was because of the `TODO` note in the code.
Even without that, do you think there is merit in supporting the create table
feature via CLI? Imo, it can be useful for quick prototyping and some simple
automation for table creation via CI/CD Github Action
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
