CTTY commented on code in PR #1511:
URL: https://github.com/apache/iceberg-rust/pull/1511#discussion_r2214352774
##########
crates/integrations/datafusion/src/table/mod.rs:
##########
@@ -157,6 +167,32 @@ impl TableProvider for IcebergTableProvider {
// Push down all filters, as a single source of truth, the scanner
will drop the filters which couldn't be push down
Ok(vec![TableProviderFilterPushDown::Inexact; filters.len()])
}
+
+ async fn insert_into(
+ &self,
+ _state: &dyn Session,
+ input: Arc<dyn ExecutionPlan>,
+ _insert_op: InsertOp,
+ ) -> DFResult<Arc<dyn ExecutionPlan>> {
+ let write_plan = Arc::new(IcebergWriteExec::new(
+ self.table.clone(),
+ input,
+ self.schema.clone(),
+ ));
+
+ if let Some(catalog) = self.catalog.clone() {
Review Comment:
Good points! fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
