CTTY commented on code in PR #1511:
URL: https://github.com/apache/iceberg-rust/pull/1511#discussion_r2210895355
##########
crates/integrations/datafusion/src/table/mod.rs:
##########
@@ -46,6 +50,8 @@ pub struct IcebergTableProvider {
snapshot_id: Option<i64>,
/// A reference-counted arrow `Schema`.
schema: ArrowSchemaRef,
+ /// The catalog that the table belongs to.
+ catalog: Option<Arc<dyn Catalog>>,
Review Comment:
This is adjusted to some existing
[APIs](https://github.com/apache/iceberg-rust/blob/a5593b4edac23a6063d321b26aff2e46ed8f9064/crates/integrations/datafusion/src/table/mod.rs#L89).
Leaving it as optional can be handy for the reading case since they can only
provide a table and don't need to care about the catalog
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
