tomtongue commented on code in PR #13549:
URL: https://github.com/apache/iceberg/pull/13549#discussion_r2213911670


##########
docs/docs/spark-procedures.md:
##########
@@ -487,7 +487,7 @@ Data files in manifests are sorted by fields in the 
partition spec. This procedu
 | Argument Name | Required? | Type | Description                               
                    |
 
|---------------|-----------|------|---------------------------------------------------------------|
 | `table`       | ✔️  | string | Name of the table to update                   
                |
-| `use_caching` | ️   | boolean | Use Spark caching during operation (defaults 
to true)         |
+| `use_caching` | ️   | boolean | Use Spark caching during operation (defaults 
to false)        |

Review Comment:
   @stevenzwu Sorry I checked it again, `use_caching` seems correct for the 
procedure as below? 
   
   
https://github.com/apache/iceberg/blob/41c0b17a20c522e4df519bcc429f413e6a2855e5/spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/procedures/RewriteManifestsProcedure.java#L54



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to