stevenzwu commented on code in PR #13549: URL: https://github.com/apache/iceberg/pull/13549#discussion_r2213858394
########## docs/docs/spark-procedures.md: ########## @@ -504,9 +504,9 @@ Rewrite the manifests in table `db.sample` and align manifest files with table p CALL catalog_name.system.rewrite_manifests('db.sample'); ``` -Rewrite the manifests in table `db.sample` and disable the use of Spark caching. This could be done to avoid memory issues on executors. +Rewrite the manifests on the partition spec `1` in table `db.sample`. ```sql -CALL catalog_name.system.rewrite_manifests('db.sample', false); +CALL catalog_name.system.rewrite_manifests(table => 'db.sample', spec_id => 1); Review Comment: The API is like `use spec id` behavior. Hence I don't quite understand the `>=` condition in the `spec_id >= 1` expression. https://github.com/apache/iceberg/blob/41c0b17a20c522e4df519bcc429f413e6a2855e5/api/src/main/java/org/apache/iceberg/actions/RewriteManifests.java#L28 https://github.com/apache/iceberg/blob/main/spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteManifestsSparkAction.java#L142 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org