jeesou commented on code in PR #13555: URL: https://github.com/apache/iceberg/pull/13555#discussion_r2209842185
########## spark/v4.0/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRewriteDataFilesProcedure.java: ########## @@ -976,19 +978,67 @@ public void testRewriteDataFilesSummary() { EnvironmentContext.ENGINE_VERSION, v -> assertThat(v).startsWith("4.0")); } + @TestTemplate Review Comment: Hi @amogh-jahagirdar can we also consider adding a test on copy-on-write vs merge-on-read scenarios? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org