amogh-jahagirdar commented on code in PR #13555:
URL: https://github.com/apache/iceberg/pull/13555#discussion_r2205301646


##########
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteDataFilesSparkAction.java:
##########
@@ -157,6 +159,12 @@ public RewriteDataFiles.Result execute() {
       return EMPTY_RESULT;
     }
 
+    // Extensions are required for custom rule which preserves lineage for 
compaction
+    if (TableUtil.supportsRowLineage(table) && 
!Spark3Util.extensionsEnabled(spark())) {
+      throw new UnsupportedOperationException(
+          "Cannot invoke rewrite data files action for V3+ tables when spark 
extensions are not enabled");

Review Comment:
   I suspect the rewrite data files action tests will fail due to this new 
check; before restructuring a bunch of tests I wanted to first demonstrate the 
idea.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to