rdblue commented on code in PR #12584: URL: https://github.com/apache/iceberg/pull/12584#discussion_r2198664432
########## open-api/rest-catalog-open-api.yaml: ########## @@ -3964,6 +4144,292 @@ components: metadata: $ref: '#/components/schemas/TableMetadata' + EventsResponse: + type: object + required: + - highest-processed-timestamp-ms + - events + properties: + next-page-token: + $ref: "#/components/schemas/PageToken" + highest-processed-timestamp-ms: + description: > + The highest event timestamp processed when generating this response. + This may not necessarily appear in the returned changes if it was filtered out. + type: integer + format: int64 + events: + type: array + items: + $ref: "#/components/schemas/Event" + + Event: + type: object + required: + - event-id + - request-id + - event-count + - timestamp-ms + - operation + properties: + event-id: + type: string + description: Unique ID of this event. Clients should perform deduplication based on this ID. + request-id: + description: > + Opaque ID of the request this change belongs to. + This ID can be used to identify events that were part of the same request. + Servers generate this ID randomly. + type: string + event-count: + type: integer + description: Number of events in the request / batch of events + timestamp-ms: + type: integer + format: int64 + description: > + Timestamp when this transaction occurred (epoch milliseconds). Review Comment: Minor: "this transaction" -> "this event"? Events may not be changes in the future, and changes aren't necessarily "transactions". We probably want to avoid using "transaction" given that it could have a specific meaning in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org