danielcweeks commented on code in PR #13215:
URL: https://github.com/apache/iceberg/pull/13215#discussion_r2195272150
##########
aws/src/main/java/org/apache/iceberg/aws/s3/signer/S3V4RestSignerClient.java:
##########
@@ -76,15 +80,25 @@ public abstract class S3V4RestSignerClient
private static final String SCOPE = "sign";
- @SuppressWarnings("immutables:incompat")
- private volatile AuthManager authManager;
+ @SuppressWarnings({"immutables:incompat", "VisibilityModifier"})
+ @VisibleForTesting
+ static volatile AuthManager authManager;
@SuppressWarnings({"immutables:incompat", "VisibilityModifier"})
@VisibleForTesting
static volatile RESTClient httpClient;
- @SuppressWarnings("immutables:incompat")
- private volatile AuthSession authSession;
+ @SuppressWarnings("ShutdownHook")
+ private static void installShutdownHook() {
Review Comment:
I don't think we're making the situation here any worse and I find shutdown
hooks not a great solution because we're adding complexity and still not
shutting them down based on when they're no longer necessary, but rather when
you're already exiting the jvm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
