adutra commented on code in PR #13215:
URL: https://github.com/apache/iceberg/pull/13215#discussion_r2194568622
##########
aws/src/main/java/org/apache/iceberg/aws/s3/signer/S3V4RestSignerClient.java:
##########
@@ -76,15 +80,25 @@ public abstract class S3V4RestSignerClient
private static final String SCOPE = "sign";
- @SuppressWarnings("immutables:incompat")
- private volatile AuthManager authManager;
+ @SuppressWarnings({"immutables:incompat", "VisibilityModifier"})
+ @VisibleForTesting
+ static volatile AuthManager authManager;
@SuppressWarnings({"immutables:incompat", "VisibilityModifier"})
@VisibleForTesting
static volatile RESTClient httpClient;
- @SuppressWarnings("immutables:incompat")
- private volatile AuthSession authSession;
+ @SuppressWarnings("ShutdownHook")
+ private static void installShutdownHook() {
Review Comment:
Fair point. I added the hook, it wasn't there before. The HTTP client for
example wasn't being closed before.
I guess it's OK to remove the hook. (I can also look into adding phantom
references here, but I'd prefer to do that in a follow-up task, since this PR
is kind of urgent.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
