kevinjqliu commented on code in PR #13459:
URL: https://github.com/apache/iceberg/pull/13459#discussion_r2192845891


##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteTablePathSparkAction.java:
##########
@@ -312,22 +313,25 @@ private String rebuildMetadata() {
   }
 
   private String saveFileList(Set<Pair<String, String>> filesToMove) {

Review Comment:
   > every one of them passes through the step of saving a file list somewhere 
and reading the files from this file list to copy them afterwards
   
   great! that was my original motivation for the test, to make sure that the 
file list is properly materialized to storage. 👍 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to