kevinjqliu commented on code in PR #13459:
URL: https://github.com/apache/iceberg/pull/13459#discussion_r2190449735
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteTablePathSparkAction.java:
##########
@@ -312,22 +313,25 @@ private String rebuildMetadata() {
}
private String saveFileList(Set<Pair<String, String>> filesToMove) {
Review Comment:
this exists in 3.4 and 4.0 as well, should we also make changes to those
files?
https://github.com/search?q=repo%3Aapache%2Ficeberg%20private%20String%20saveFileList&type=code
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteTablePathSparkAction.java:
##########
@@ -312,22 +313,25 @@ private String rebuildMetadata() {
}
private String saveFileList(Set<Pair<String, String>> filesToMove) {
Review Comment:
nit: can we add a test for this in
https://github.com/apache/iceberg/blob/main/spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewriteTablePathsAction.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
