danielcweeks commented on code in PR #12562:
URL: https://github.com/apache/iceberg/pull/12562#discussion_r2183055209
##########
core/src/main/java/org/apache/iceberg/rest/auth/OAuth2Manager.java:
##########
@@ -61,7 +61,7 @@ public class OAuth2Manager extends RefreshingAuthManager {
private RESTClient refreshClient;
private long startTimeMillis;
private OAuthTokenResponse authResponse;
- private AuthSessionCache sessionCache;
+ private AuthManagerSessionCache<String, OAuth2Util.AuthSession> sessionCache;
Review Comment:
Don't you want this to be `AuthManagerSessionCache<Object,
OAuth2Util.AuthSession>`? I don't think we need to preserve the string generic
or maybe I'm misunderstanding what the end state is. If we don't have the new
protected `newAuthSessionCache` return a wider generic, we'll have to go
through another deprecation cycle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
