nastra commented on code in PR #12562:
URL: https://github.com/apache/iceberg/pull/12562#discussion_r2182312845
##########
core/src/main/java/org/apache/iceberg/rest/auth/OAuth2Manager.java:
##########
@@ -156,19 +156,28 @@ public OAuth2Util.AuthSession tableSession(
@Override
public void close() {
- try {
+ AuthManagerSessionCache<String, OAuth2Util.AuthSession> cache =
sessionCache;
+ this.sessionCache = null;
+ try (cache) {
super.close();
- } finally {
- AuthSessionCache cache = sessionCache;
- this.sessionCache = null;
- if (cache != null) {
- cache.close();
- }
}
}
+ /**
+ * @deprecated since 1.10.0, will be removed in 1.11.0; use {@link
#newAuthSessionCache(String,
+ * Map)}
+ */
+ @Deprecated
protected AuthSessionCache newSessionCache(String managerName, Map<String,
String> properties) {
- return new AuthSessionCache(managerName, sessionTimeout(properties));
Review Comment:
we can't return null here as that would be a behavioral change. We can only
deprecate and leave the impl as-is. Also I don't think we need the
`AuthManagerSessionCacheAdapter`. We would basically keep `newSessionCache`
as-is and then have `newAuthSessionCache` that returns the parameterized
version of the cache
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
