pvary commented on PR #13433: URL: https://github.com/apache/iceberg/pull/13433#issuecomment-3026778235
> Gluten doesn't handle the delete files in this way, so ideally for Gluten's case we can just avoid inheriting from the `SupportsDeleteFilter` interface? I can do more study around here, but the intuition is that we have to have a way to get the original delete files information so it can be pushed to C++ code. This was one of the reasons we removed the delete file handling from the File Format API. It is only used in a single place currently, likely a more generic solution will be needed if we start using it in multiple places. > By the way, I am not sure if the community is interested with adding a Velox-based reader / writer implementation in the code base? Gluten + Iceberg development and test could be made easy, and it could also help Iceberg's new reader / writer API evolve in place. I think the most realistic plan would be that Iceberg provides a standard API and tests for certification. Engines and File Formats themselves would be responsible to provide the implementations (likely outside of the Iceberg codebase). You have to understand that we are in the early stages of this discussion, and my view might not be aligned with the broader communities view. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
