zhztheplayer commented on code in PR #13433:
URL: https://github.com/apache/iceberg/pull/13433#discussion_r2175544751


##########
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/SparkSQLProperties.java:
##########
@@ -19,11 +19,18 @@
 package org.apache.iceberg.spark;
 
 import java.time.Duration;
+import org.apache.iceberg.spark.source.BaseSparkPartitionReaderFactoryProvider;
 
 public class SparkSQLProperties {
 
   private SparkSQLProperties() {}
 
+  // Specifies an implementation class of SparkPartitionReaderFactoryProvider
+  public static final String PARTITION_READER_FACTORY_PROVIDER =
+      "spark.sql.iceberg.partition-reader-factory.provider";
+  public static final String PARTITION_READER_FACTORY_PROVIDER_DEFAULT =
+      BaseSparkPartitionReaderFactoryProvider.class.getName();
+

Review Comment:
   This will only take effect for Spark 4.0. 
   
   I will add support for 3.4 and 3.5 as well if the community is good with the 
change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to