RussellSpitzer commented on code in PR #11868:
URL: https://github.com/apache/iceberg/pull/11868#discussion_r2178279289
##########
api/src/main/java/org/apache/iceberg/PartitionSpec.java:
##########
@@ -132,6 +132,12 @@ public StructType partitionType() {
for (PartitionField field : fields) {
Type sourceType = schema.findType(field.sourceId());
Type resultType = field.transform().getResultType(sourceType);
+
+ // When the source field has been dropped we cannot determine the
type
+ if (resultType == null) {
Review Comment:
This is the only change i'm not sure of, What's the value of not leaving
this null? To me unknown specifies that the type could (and will be set) in the
future but in this case the partition spec is essentially now dead and will
never have a valid response?
I don't know if it matters really that much but I was wondering what the
motivation was for the change here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
