stevenzwu commented on code in PR #11868:
URL: https://github.com/apache/iceberg/pull/11868#discussion_r2178078668
##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestAlterTablePartitionFields.java:
##########
@@ -583,4 +587,44 @@ private void createTable(String schema, String spec) {
tableName, schema, spec, TableProperties.FORMAT_VERSION,
formatVersion);
}
}
+
+ private void runCreateAndDropPartitionField(
+ String column, String partitionType, List<Object[]> expected, String
predicate) {
+ sql("DROP TABLE IF EXISTS %s", tableName);
+ sql(
+ "CREATE TABLE %s (col_int INTEGER, col_ts TIMESTAMP_NTZ, col_long
BIGINT) USING ICEBERG TBLPROPERTIES ('format-version' = %d)",
+ tableName, formatVersion);
+ sql("INSERT INTO %s VALUES (1000, CAST('2024-03-01 19:25:00' as
TIMESTAMP), 2100)", tableName);
Review Comment:
sorry, I meant the numbers. e.g. every number in this line have a `3`. the
next line is mainly `4`. just nit visual difference so that I wasn't distracted
by `19:25:00` etc. really minor :)
```
3, CAST('2024-03-01 00:00:00' as TIMESTAMP), 3000
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
