adutra commented on code in PR #12562:
URL: https://github.com/apache/iceberg/pull/12562#discussion_r2177290845
##########
.palantir/revapi.yml:
##########
@@ -1178,6 +1178,33 @@ acceptedBreaks:
new: "class org.apache.iceberg.Metrics"
justification: "Java serialization across versions is not guaranteed"
org.apache.iceberg:iceberg-core:
+ - code: "java.generics.elementNowParameterized"
Review Comment:
> I don't think we should be breaking the API. Instead it's probably best to
introduce a new class and deprecate the old one.
Yes I'm OK with that. I will update the PR.
> Do we actually have use cases that require a parameterized cache? If so,
could you please link to some examples in order for me to better understand why
we're doing these changes (in the description you mentioned that you're seeing
a common pattern, but it would be good to share where those patterns are used)
Yes, the Dremio Auth Manager has a different caching pattern:
https://github.com/dremio/iceberg-auth-manager/blob/93517cb30700507f2be5c5688508ca9d0d081c76/oauth2/core/src/main/java/com/dremio/iceberg/authmgr/oauth2/cache/AuthSessionCache.java
The caching pattern here is imo a fairly natural one: we use a configuration
class as the key, so that every time the same configuration comes up again, we
reuse the cached session.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
