nastra commented on code in PR #12562: URL: https://github.com/apache/iceberg/pull/12562#discussion_r2176580216
########## .palantir/revapi.yml: ########## @@ -1178,6 +1178,33 @@ acceptedBreaks: new: "class org.apache.iceberg.Metrics" justification: "Java serialization across versions is not guaranteed" org.apache.iceberg:iceberg-core: + - code: "java.generics.elementNowParameterized" Review Comment: I don't think we should be breaking the API. Instead it's probably best to introduce a new class and deprecate the old one. Do we actually have use cases that require a parameterized cache? If so, could you please link to some examples in order for me to better understand why we're doing these changes (in the description you mentioned that you're seeing a common pattern, but it would be good to share where those patterns are used) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org