Fokko commented on issue #2132: URL: https://github.com/apache/iceberg-python/issues/2132#issuecomment-3018200029
Thanks, @Xiezhibin, for being willing to work on this! > Do we need to annotate the `snapshot_properties` parameter as `Optional` in `iceberg-python/pyiceberg/table/__init__.py`? No, I don't think this is needed, the `EMPTY_DICT` avoids doing null-checks :) 4. How should I modify the documentation? Should I add an example that includes `snapshot_properties` and `check_duplicate_files`, or should I modify the existing example to demonstrate the optional parameters? I think we can add a table here: https://github.com/apache/iceberg-python/blob/5e975d569e243f1e67e8021a6f941cd77b08d926/mkdocs/docs/api.md?plain=1#L1064 Similar to how it is done for Java: https://iceberg.apache.org/docs/nightly/spark-procedures/#usage_1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
