kevinjqliu commented on issue #2132: URL: https://github.com/apache/iceberg-python/issues/2132#issuecomment-3071834144
this is the `add_files` function signature https://github.com/apache/iceberg-python/blob/86bf71ceb602061d0958619ebd806aaccde348b3/pyiceberg/table/__init__.py#L861 we dont need to worry about `snapshot_properties` lets add documentation to mention that `check_duplicate_files` is by default `True` and this will check the new files against the existing iceberg table data files, which can be expensive. `check_duplicate_files` can be turned off. but add a caution that this can lead to data consistency / table corruption issues if the same data file is added multiple times https://py.iceberg.apache.org/api/#files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
