anuragmantri commented on code in PR #12893:
URL: https://github.com/apache/iceberg/pull/12893#discussion_r2167612225
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/BatchDataReader.java:
##########
@@ -50,15 +50,17 @@ class BatchDataReader extends BaseBatchReader<FileScanTask>
BatchDataReader(
SparkInputPartition partition,
ParquetBatchReadConf parquetBatchReadConf,
- OrcBatchReadConf orcBatchReadConf) {
+ OrcBatchReadConf orcBatchReadConf,
Review Comment:
I had considered that, but it became harder to pass the flag back to parent
class (for SparkDeleteFilter creation) since BatchDataReader is common class
for both parquet and orc (I would have to do null checks and get the flag)
Also, this property is a format agnostic one, while the
`<format>BatchReadConf` are for format specific properties.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
