RussellSpitzer commented on code in PR #12893:
URL: https://github.com/apache/iceberg/pull/12893#discussion_r2167491719
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/BatchDataReader.java:
##########
@@ -50,15 +50,17 @@ class BatchDataReader extends BaseBatchReader<FileScanTask>
BatchDataReader(
SparkInputPartition partition,
ParquetBatchReadConf parquetBatchReadConf,
- OrcBatchReadConf orcBatchReadConf) {
+ OrcBatchReadConf orcBatchReadConf,
Review Comment:
For this and parquet we should probably add to the Conf object. Ie
OrcBatchReadConf.cacheDeleteFiles
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
