amogh-jahagirdar commented on code in PR #13386:
URL: https://github.com/apache/iceberg/pull/13386#discussion_r2167001538
##########
core/src/main/java/org/apache/iceberg/rest/BaseHTTPClient.java:
##########
@@ -149,10 +149,16 @@ protected abstract <T extends RESTResponse> T execute(
Consumer<ErrorResponse> errorHandler,
Consumer<Map<String, String>> responseHeaders);
- protected abstract <T extends RESTResponse> T execute(
+ protected <T extends RESTResponse> T execute(
HTTPRequest request,
Class<T> responseType,
Consumer<ErrorResponse> errorHandler,
Consumer<Map<String, String>> responseHeaders,
- ParserContext parserContext);
+ ParserContext parserContext) {
+ if (null != parserContext) {
+ throw new UnsupportedOperationException("Parser context is not
supported");
+ }
+
+ return execute(request, responseType, errorHandler, responseHeaders);
Review Comment:
> is the intention to just have one abstract method for execute
@singhpk234 I think it's more in general that when there's an opportunity
to avoid public classes being forced to implement something on upgrade we
should try do it that way since we can establish an opinionated default
implementation; it's not always possible but here it is.
So specifically prior to this change client implementations were already
forced to implement `execute` without the parser context, and after #13191 they
would have to implement an additional `execute`. Since there was an easy way to
avoid that by just having a non-abstract implementation which still just fails
at runtime, it seems worth it to avoid any existing client implementations from
having to just override it themselves.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
