singhpk234 commented on code in PR #13386:
URL: https://github.com/apache/iceberg/pull/13386#discussion_r2166965647
##########
core/src/main/java/org/apache/iceberg/rest/BaseHTTPClient.java:
##########
@@ -149,10 +149,16 @@ protected abstract <T extends RESTResponse> T execute(
Consumer<ErrorResponse> errorHandler,
Consumer<Map<String, String>> responseHeaders);
- protected abstract <T extends RESTResponse> T execute(
+ protected <T extends RESTResponse> T execute(
HTTPRequest request,
Class<T> responseType,
Consumer<ErrorResponse> errorHandler,
Consumer<Map<String, String>> responseHeaders,
- ParserContext parserContext);
+ ParserContext parserContext) {
+ if (null != parserContext) {
+ throw new UnsupportedOperationException("Parser context is not
supported");
+ }
+
+ return execute(request, responseType, errorHandler, responseHeaders);
Review Comment:
isn't the execute without parserContext still abstract ? except the parser
context being package protected ?
```
protected abstract <T extends RESTResponse> T execute(
HTTPRequest request,
Class<T> responseType,
Consumer<ErrorResponse> errorHandler,
Consumer<Map<String, String>> responseHeaders);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
