anuragmantri commented on code in PR #12893: URL: https://github.com/apache/iceberg/pull/12893#discussion_r2167399580
########## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkExecutorCache.java: ########## @@ -70,10 +70,10 @@ private SparkExecutorCache(Conf conf) { * * <p>Note this method returns null if caching is disabled. */ - public static SparkExecutorCache getOrCreate() { + public static SparkExecutorCache getOrCreate(boolean forDeletes) { Review Comment: I took a different approach so this is obsolete. ########## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkExecutorCache.java: ########## @@ -70,10 +70,10 @@ private SparkExecutorCache(Conf conf) { * * <p>Note this method returns null if caching is disabled. */ - public static SparkExecutorCache getOrCreate() { Review Comment: I took a different approach so this is obsolete. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org