anuragmantri commented on PR #12893: URL: https://github.com/apache/iceberg/pull/12893#issuecomment-3005820747
Thanks for the reviews folks. So I took a different approach of plumbing this way back from SparkBatch into all the reader factories and finally into the `BaseReader`. There are a lot of changes. Alternative would be to read spark conf dynamically within `BaseReader` but that did not seem consistent with other such read configurations like `caseSensitive`. Let me know if this approach is reasonable, I will try to add some tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
