Fokko commented on code in PR #2148:
URL: https://github.com/apache/iceberg-python/pull/2148#discussion_r2164079794
##########
pyiceberg/catalog/rest/__init__.py:
##########
@@ -178,12 +178,12 @@ class RegisterTableRequest(IcebergBaseModel):
class ConfigResponse(IcebergBaseModel):
- defaults: Properties = Field()
+ defaults: Optional[Properties] = Field(default={})
Review Comment:
```suggestion
defaults: Optional[Properties] = Field(default_factory=dict)
```
##########
pyiceberg/catalog/rest/__init__.py:
##########
@@ -178,12 +178,12 @@ class RegisterTableRequest(IcebergBaseModel):
class ConfigResponse(IcebergBaseModel):
- defaults: Properties = Field()
+ defaults: Optional[Properties] = Field(default={})
overrides: Properties = Field()
class ListNamespaceResponse(IcebergBaseModel):
- namespaces: List[Identifier] = Field()
+ namespaces: Optional[List[Identifier]] = Field(default=[])
Review Comment:
```suggestion
namespaces: Optional[List[Identifier]] = Field(default_factory=list)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
