liurenjie1024 commented on code in PR #1451:
URL: https://github.com/apache/iceberg-rust/pull/1451#discussion_r2159817079
##########
crates/iceberg/src/transaction/mod.rs:
##########
@@ -157,41 +114,45 @@ impl Transaction {
/// Commit transaction.
pub async fn commit(mut self, catalog: &dyn Catalog) -> Result<Table> {
- if self.actions.is_empty() && self.updates.is_empty() {
+ if self.actions.is_empty() {
// nothing to commit
- return Ok(self.base_table.clone());
+ return Ok(self.table.clone());
}
self.do_commit(catalog).await
}
async fn do_commit(&mut self, catalog: &dyn Catalog) -> Result<Table> {
- let base_table_identifier = self.base_table.identifier().to_owned();
+ let base_table_identifier = self.table.identifier().to_owned();
Review Comment:
Why we need to call `to_owned`? The `load_table` accepts a reference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
