CTTY commented on code in PR #1451:
URL: https://github.com/apache/iceberg-rust/pull/1451#discussion_r2159688238
##########
crates/iceberg/src/transaction/mod.rs:
##########
@@ -45,60 +45,55 @@ use crate::{Catalog, TableCommit, TableRequirement,
TableUpdate};
/// Table transaction.
pub struct Transaction {
- base_table: Table,
- current_table: Table,
+ table: Table,
actions: Vec<BoxedTransactionAction>,
- updates: Vec<TableUpdate>,
- requirements: Vec<TableRequirement>,
}
impl Transaction {
/// Creates a new transaction.
pub fn new(table: &Table) -> Self {
Self {
- base_table: table.clone(),
- current_table: table.clone(),
+ table: table.clone(),
actions: vec![],
- updates: vec![],
- requirements: vec![],
}
}
- fn update_table_metadata(&mut self, updates: &[TableUpdate]) -> Result<()>
{
- let mut metadata_builder =
self.current_table.metadata().clone().into_builder(None);
+ fn update_table_metadata(&self, table: &mut Table, updates:
&[TableUpdate]) -> Result<()> {
Review Comment:
Good point! Will fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
