pvary commented on code in PR #13302: URL: https://github.com/apache/iceberg/pull/13302#discussion_r2159282127
########## core/src/main/java/org/apache/iceberg/util/FileSystemWalker.java: ########## @@ -0,0 +1,266 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.util; + +import java.io.IOException; +import java.io.UncheckedIOException; +import java.util.List; +import java.util.function.Consumer; +import java.util.function.Predicate; +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.fs.FileStatus; +import org.apache.hadoop.fs.FileSystem; +import org.apache.hadoop.fs.Path; +import org.apache.hadoop.fs.PathFilter; +import org.apache.iceberg.io.FileInfo; +import org.apache.iceberg.io.SupportsPrefixOperations; +import org.apache.iceberg.relocated.com.google.common.collect.Lists; + +/** + * Utility class for recursively traversing file systems and identifying hidden paths. Provides + * methods to list files recursively while filtering out hidden paths based on specified criteria. + */ +public class FileSystemWalker { + + private FileSystemWalker() {} + + /** + * Recursively lists files in the specified directory that satisfy the given conditions. + * + * @param io File system interface supporting prefix operations + * @param dir Base directory to start recursive listing + * @param predicate Additional filter condition for files + * @param pathFilter Filter to identify hidden paths + * @return List to collect matching file locations + */ + public static List<String> listDirRecursivelyWithFileIO( Review Comment: Do we need these non-consumer based public APIs? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
