pvary commented on code in PR #13302:
URL: https://github.com/apache/iceberg/pull/13302#discussion_r2159360815
##########
flink/v2.0/flink/src/test/java/org/apache/iceberg/flink/maintenance/api/MaintenanceTaskTestBase.java:
##########
@@ -41,7 +41,7 @@ void runAndWaitForSuccess(
ManualSource<Trigger> triggerSource,
CollectingSink<TaskResult> collectingSink)
throws Exception {
- runAndWaitForResult(env, triggerSource, collectingSink, false, () -> true);
+ runAndWaitForResult(env, triggerSource, collectingSink, false, () -> true,
true);
Review Comment:
This many boolean parameters makes reading the code hard. We should start
following the pattern to add the name for the boolean variable which we provide
as a parameter to better understand the code.
Like: `runAndWaitForResult(env, triggerSource, collectingSink, false
/*generateFailure */, () -> true /* waitForCondition */, true /* resultSuccess
*/)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
