sungwy commented on code in PR #13212: URL: https://github.com/apache/iceberg/pull/13212#discussion_r2150083115
########## gcp/src/main/java/org/apache/iceberg/gcp/auth/GoogleAuthManager.java: ########## @@ -0,0 +1,149 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.gcp.auth; + +import com.google.auth.oauth2.GoogleCredentials; +import java.io.FileInputStream; +import java.io.IOException; +import java.io.UncheckedIOException; +import java.util.List; +import java.util.Map; +import org.apache.iceberg.catalog.SessionCatalog; +import org.apache.iceberg.catalog.TableIdentifier; +import org.apache.iceberg.relocated.com.google.common.base.Preconditions; +import org.apache.iceberg.relocated.com.google.common.base.Splitter; +import org.apache.iceberg.relocated.com.google.common.base.Strings; +import org.apache.iceberg.relocated.com.google.common.collect.ImmutableList; +import org.apache.iceberg.rest.RESTClient; +import org.apache.iceberg.rest.auth.AuthManager; +import org.apache.iceberg.rest.auth.AuthSession; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * An authentication manager that uses Google Credentials (typically Application Default + * Credentials) to create {@link GoogleAuthSession} instances. + * + * <p>This manager can be configured with properties such as: + * + * <ul> + * <li>{@code gcp.auth.credentials-path}: Path to a service account JSON key file. If not set, + * Application Default Credentials will be used. + * <li>{@code gcp.auth.scopes}: Comma-separated list of OAuth scopes to request. Defaults to + * "https://www.googleapis.com/auth/cloud-platform";. + * </ul> + */ +public class GoogleAuthManager implements AuthManager { + private static final Logger LOG = LoggerFactory.getLogger(GoogleAuthManager.class); + private static final Splitter SPLITTER = Splitter.on(',').trimResults().omitEmptyStrings(); + public static final String DEFAULT_SCOPES = "https://www.googleapis.com/auth/cloud-platform";; Review Comment: This default scope seems strange to me: is this intended to be used as the default scope for the Iceberg Rest Catalog Server? Why would we want to include this scope in the authorization token to the Iceberg REST Catalog that understands read/write and table and catalog like entities? I'm wondering if this was just included because this is the default value available in the google-auth user guides, but isn't necessary relevant here: https://googleapis.dev/python/google-auth/latest/user-guide.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
