nastra commented on code in PR #13212:
URL: https://github.com/apache/iceberg/pull/13212#discussion_r2125989326
##########
gcp/src/main/java/org/apache/iceberg/gcp/GCPProperties.java:
##########
@@ -62,6 +62,9 @@ public class GCPProperties implements Serializable {
*/
public static final int GCS_DELETE_BATCH_SIZE_DEFAULT = 50;
+ public static final String GCP_CREDENTIALS_PATH_PROPERTY =
"gcp.auth.credentials-path";
Review Comment:
I'm currently not sure whether these properties should be here vs in
`GoogleAuthManager`. The properties in this class are typically related to the
FileIO implementation of GCS, whereas these new properties aren't
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
