zhangwl9 commented on PR #13187: URL: https://github.com/apache/iceberg/pull/13187#issuecomment-2974855935
> @zhangwl9 keep the original commit history, and stop squashing unless you are requested, otherwise reviewers have no idea what your change is after each round of reviewing. Also, providing valid manual test results after each change, since it is not covered by UT.保留原始提交历史，除非被要求，否则不要合并，否则审阅者每次审阅后都不知道你的改动是什么。此外，每次改动后都要提供有效的手动测试结果，因为这不包含在单元测试中。 > > > the current value of each HMS's metastoreuri is used as the key, and is saved to credientials along with the corresponding token每个 HMS 的 metastoreuri 当前值被用作键，并连同相应的 token 保存在凭证中 > > Okay, you use metastore uris as the signature in the token producer to distinguish different HMSs. Then what about the consumer side? Is Hive client smart enough to know which token it should pick?好的，你在 token 生产者中使用 metastore uris 作为签名来区分不同的 HMS。那么消费者端呢？Hive 客户端足够智能，知道该选择哪个 token 吗？ @pan3793 I have now added metastoreUri for token as a service does it solve your query? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
