pan3793 commented on PR #13187: URL: https://github.com/apache/iceberg/pull/13187#issuecomment-2969397615
@zhangwl9 keep the original commit history, and stop squashing unless you are requested, otherwise reviewers have no idea what your change is after each round of reviewing. Also, providing valid manual test results after each change, since it is not covered by UT. > the current value of each HMS's metastoreuri is used as the key, and is saved to credientials along with the corresponding token Okay, you use metastore uris as the signature in the token producer to distinguish different HMSs. Then what about the consumer side? Is Hive client smart enough to know which token it should pick? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
