smaheshwar-pltr commented on code in PR #2031:
URL: https://github.com/apache/iceberg-python/pull/2031#discussion_r2134818675
##########
pyiceberg/table/__init__.py:
##########
@@ -1507,16 +1566,17 @@ def _parse_row_filter(expr: Union[str,
BooleanExpression]) -> BooleanExpression:
return parser.parse(expr) if isinstance(expr, str) else expr
-S = TypeVar("S", bound="TableScan", covariant=True)
+S = TypeVar("S", bound="AbstractTableScan", covariant=True)
-class TableScan(ABC):
+class AbstractTableScan(ABC):
Review Comment:
See
https://github.com/apache/iceberg-python/pull/2031#discussion_r2102727321 -
`TableScan` still exists with the same methods so I'd have thought we'd be fine
here, or do I misunderstand?
The purpose of this new class is a base class for table scans, including
incremental ones, because logic can be shared. But your point about
reconsidering class hierarchy still holds
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
