Fokko commented on code in PR #2031:
URL: https://github.com/apache/iceberg-python/pull/2031#discussion_r2134798610
##########
pyiceberg/table/__init__.py:
##########
@@ -1507,16 +1566,17 @@ def _parse_row_filter(expr: Union[str,
BooleanExpression]) -> BooleanExpression:
return parser.parse(expr) if isinstance(expr, str) else expr
-S = TypeVar("S", bound="TableScan", covariant=True)
+S = TypeVar("S", bound="AbstractTableScan", covariant=True)
-class TableScan(ABC):
+class AbstractTableScan(ABC):
Review Comment:
Do we _need_ to do this name? Changing the name would break any other
library that relies on this class.
##########
pyiceberg/table/__init__.py:
##########
@@ -1507,16 +1566,17 @@ def _parse_row_filter(expr: Union[str,
BooleanExpression]) -> BooleanExpression:
return parser.parse(expr) if isinstance(expr, str) else expr
-S = TypeVar("S", bound="TableScan", covariant=True)
+S = TypeVar("S", bound="AbstractTableScan", covariant=True)
-class TableScan(ABC):
+class AbstractTableScan(ABC):
Review Comment:
Do we _need_ to do this rename? Changing the name would break any other
library that relies on this class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
