Fokko commented on code in PR #1833: URL: https://github.com/apache/iceberg-python/pull/1833#discussion_r2134070839
########## pyproject.toml: ########## @@ -289,7 +289,7 @@ generate-setup-file = false script = "build-module.py" [tool.poetry.extras] -pyarrow = ["pyarrow"] +pyarrow = ["pyarrow", "pyiceberg-core"] Review Comment: > Also I think the pyarrow_transform functions are used on the read path too For completeness, I don't think that's true. `_determine_partitions` is only used by `_dataframe_to_data_files`. When reading, we often have a single value `SELECT * FROM tbl WHERE created_at > '2025-01-01 19:25:00'`, so there performance is not that important, and we use non-Arrow transform ([example for the MonthPartitioning](https://github.com/apache/iceberg-python/blob/f507dbd1c29c7d21d24c6f2f7b4479cde2be16de/pyiceberg/transforms.py#L529-L556)). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
