Fokko commented on code in PR #1833: URL: https://github.com/apache/iceberg-python/pull/1833#discussion_r2134062259
########## pyproject.toml: ########## @@ -289,7 +289,7 @@ generate-setup-file = false script = "build-module.py" [tool.poetry.extras] -pyarrow = ["pyarrow"] +pyarrow = ["pyarrow", "pyiceberg-core"] Review Comment: __technically__ this is not required, because we only use the transforms when writing to a partitioned table. But I think that it might lead to a lot of confusion if we don't do this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
