mxm commented on code in PR #13072:
URL: https://github.com/apache/iceberg/pull/13072#discussion_r2128234653
##########
flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/source/FlinkSource.java:
##########
@@ -133,15 +133,6 @@ public Builder setAll(Map<String, String> properties) {
return this;
}
- /**
- * @deprecated Use {@link #setAll} instead.
- */
- @Deprecated
- public Builder properties(Map<String, String> properties) {
- readOptions.putAll(properties);
- return this;
- }
-
Review Comment:
This is an unrelated change, no?
##########
flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/source/IcebergSource.java:
##########
@@ -545,15 +557,6 @@ public Builder<T> watermarkColumnTimeUnit(TimeUnit
timeUnit) {
return this;
}
- /**
- * @deprecated Use {@link #setAll} instead.
- */
- @Deprecated
- public Builder<T> properties(Map<String, String> properties) {
- readOptions.putAll(properties);
- return this;
- }
-
Review Comment:
Unrelated change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
