kevinjqliu commented on code in PR #2013:
URL: https://github.com/apache/iceberg-python/pull/2013#discussion_r2122698502
##########
tests/integration/test_reads.py:
##########
@@ -111,6 +112,23 @@ def test_table_properties(catalog: Catalog) -> None:
table.transaction().set_properties(property_name=None).commit_transaction()
Review Comment:
This PR will save the properties in both the HMS tableparameter **and**
table metadata's properties field
##########
tests/integration/test_reads.py:
##########
@@ -111,6 +112,23 @@ def test_table_properties(catalog: Catalog) -> None:
table.transaction().set_properties(property_name=None).commit_transaction()
Review Comment:
This PR will save the properties in both the HMS's table parameter **and**
table metadata's properties field
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
