kadai0308 commented on code in PR #2013:
URL: https://github.com/apache/iceberg-python/pull/2013#discussion_r2106145510
##########
pyiceberg/catalog/hive.py:
##########
@@ -211,11 +211,18 @@ def _construct_hive_storage_descriptor(
DEFAULT_PROPERTIES = {TableProperties.PARQUET_COMPRESSION:
TableProperties.PARQUET_COMPRESSION_DEFAULT}
-def _construct_parameters(metadata_location: str, previous_metadata_location:
Optional[str] = None) -> Dict[str, Any]:
+def _construct_parameters(
+ metadata_location: str, previous_metadata_location: Optional[str] = None,
metadata_properties: Optional[Properties] = None
+) -> Dict[str, Any]:
properties = {PROP_EXTERNAL: "TRUE", PROP_TABLE_TYPE: "ICEBERG",
PROP_METADATA_LOCATION: metadata_location}
if previous_metadata_location:
properties[PROP_PREVIOUS_METADATA_LOCATION] =
previous_metadata_location
+ if metadata_properties:
+ for key, value in metadata_properties.items():
Review Comment:
After going through the code, I’m not sure what you mean by “handle removed
properties.” Aren’t they already removed, since they are overwritten in:
```python
hive_table.parameters = _construct_parameters(
metadata_location=updated_staged_table.metadata_location,
previous_metadata_location=current_table.metadata_location,
metadata_properties=updated_staged_table.properties,
)
```
And the metadata_properties come from `updated_staged_table.properties`,
which should already have the updated and removed properties handled at:
`updated_staged_table = self._update_and_stage_table(current_table,
table_identifier, requirements, updates)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
