kevinjqliu commented on code in PR #447:
URL: https://github.com/apache/iceberg-go/pull/447#discussion_r2114465579
##########
dev/release/release.sh:
##########
@@ -40,16 +40,40 @@ fi
tag="v${version}"
rc_tag="${tag}-rc${rc}"
echo "Tagging for release: ${tag}"
-git tag "${tag}" "${rc_tag}"
+git tag "${tag}" "${rc_tag}^{}" -m "Release ${tag}"
Review Comment:
+1 `"${rc_tag}^{}"` means return the commit for this tag
##########
dev/release/release.sh:
##########
@@ -40,16 +40,40 @@ fi
tag="v${version}"
rc_tag="${tag}-rc${rc}"
echo "Tagging for release: ${tag}"
-git tag "${tag}" "${rc_tag}"
+git tag "${tag}" "${rc_tag}^{}" -m "Release ${tag}"
git push origin "${tag}"
+release_id="apache-iceberg-go-${version}"
dist_url="https://dist.apache.org/repos/dist/release/iceberg";
dist_dev_url="https://dist.apache.org/repos/dist/dev/iceberg";
+dist_base_dir="dev/release/dist"
+dist_dir="${dist_base_dir}/${release_id}"
-svn \
- mv "${dist_dev_url}/apache-iceberg-go-${version}-rc${rc}/" \
- "${dist_url}/apache-iceberg-go-${version}/" \
- -m "Apache Iceberg-go ${version}"
+rm -rf "${dist_base_dir}"
+svn co --depth=empty "${dist_url}" "${dist_base_dir}"
+gh release download "${rc_tag}" \
+ --dir "${dist_dir}" \
+ --skip-existing
Review Comment:
nit, i think we should download from apache instead, using `dist_dev_url`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
