liurenjie1024 commented on PR #1361:
URL: https://github.com/apache/iceberg-rust/pull/1361#issuecomment-2918988524

   > Hi @liurenjie1024, by default `reqwests` uses the `openssl` library of the 
system (vendored openssl) to connect to servers via TLS / HTTPS. This creates a 
runtime dependency on the underlying system to have a compatible `openssl` 
library installed.
   > 
   > `rustls` is rust-native implementation of openssl which removes this 
runtime dependency. This is very helpful to build platform agnostic binaries as 
well as building minimal docker images. Lakekeeper for example is build on the 
google [distroless images](https://github.com/GoogleContainerTools/distroless) 
stack. The minimal distroless incompatible is incompatible with `iceberg-rust` 
due to the missing runtime depdendency of openssl. To remove this runtime 
dependency, we currently hard-coded `rustls-tls` in our fork: 
https://github.com/lakekeeper/iceberg-rust/blob/a8b6509775b139c92772a999b0cbca637e274a03/Cargo.toml#L100
   
   Thanks @c-thiel for explaination. How about making `rustls-tls` and 
`rustls-tls-native-roots` default? This way our user don't rely on system 
openssl by default. We could add an option for openssl.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to