liurenjie1024 commented on issue #1314:
URL: https://github.com/apache/iceberg-rust/issues/1314#issuecomment-2918961357
> I'm not sure if I understand this though, especially the difference
between FileIO and DynFileIO. Also it seems InputFile etc. are trait now, and
I'm worried that it may add burden to the implementer.
It will not. Vendors just need to implent `FileIO` trait, which ensures
strong type check. And we can auto implement `DynFileIO` for any type that
implements `FileIO`, like following:
```rust
impl<T: FileIO> DynFileIO for T {
}
```
> Make Storage a trait -
https://github.com/apache/iceberg-rust/issues/1314#issuecomment-2880758072
I would vote for this one, with this approach we have two benefits:
1. Allowing user to provide its own implementation
2. We could move concrete implementations out of core crate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
