tustvold commented on issue #1314: URL: https://github.com/apache/iceberg-rust/issues/1314#issuecomment-2893032985
> I still recommend wrapping it in a struct when passing around in the crate So are you proposing making Storage a trait instead? If so for the sake of argument, could this just be ObjectStore? > Should we have an unified FileIOBuilder trait FWIW we are upstreaming the ObjectStoreRegistry abstraction from DF that may serve as inspiration - https://github.com/apache/arrow-rs-object-store/pull/375 > Should we only keep traits like FileIO(and potentially FileIOBuilder) in core crate, and move concrete implementation to other crate? Just like what we did for Catalog This seems sensible to me FWIW -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
