liurenjie1024 commented on issue #1382:
URL: https://github.com/apache/iceberg-rust/issues/1382#issuecomment-2918834688

   > [@CTTY](https://github.com/CTTY) 
[@liurenjie1024](https://github.com/liurenjie1024) I'm wondering about the 
commit path proposed for the memory catalog in 
[#1381](https://github.com/apache/iceberg-rust/pull/1381) , which does 
[#1388](https://github.com/apache/iceberg-rust/issues/1388) and 
[#1389](https://github.com/apache/iceberg-rust/issues/1389) , but not the other 
two things. I think the retries aren't needed because the memory catalog uses 
an explicit lock rather than optimistic concurrency, and it doesn't seem 
necessary to me to have TableCommit provide a create_new_metadata function 
rather than applying the updates in the catalog. Thoughts on this?
   
   Hi, @hsingh574 Using a lock doesn't mean it can't do optimistic concurrency 
control. The retry is used to validate that all table requiremens are met.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to